Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation for using private registry #360

Merged
merged 3 commits into from
Aug 12, 2024
Merged

add documentation for using private registry #360

merged 3 commits into from
Aug 12, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 12, 2024 •
edited
Loading

Proposed changes

Add documentation for installing from the operator images (including kube-rbac-proxy) from a private container registry

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 12, 2024 10:14
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 12, 2024
jjngx
jjngx approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pdabelf5 pdabelf5 merged commit 3a987f5 into main Aug 12, 2024
6 checks passed
@pdabelf5 pdabelf5 deleted the registry-docs branch August 12, 2024 13:37
@pdabelf5 pdabelf5 linked an issue Aug 13, 2024 that may be closed by this pull request
POC - Operator - Image registry consolidation #348
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

@ADubhlaoich ADubhlaoich Awaiting requested review from ADubhlaoich

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POC - Operator - Image registry consolidation
3 participants
@pdabelf5 @j1m-ryan @jjngx