Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for API version 6 #108

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Add support for API version 6 #108

merged 5 commits into from
Jul 15, 2022

Conversation

lucacome
Copy link
Member

Closes #107

@lucacome lucacome requested review from pleshakov and a team July 14, 2022 23:40
@lucacome lucacome self-assigned this Jul 14, 2022
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jul 14, 2022
@lucacome lucacome requested review from ciarams87 and jjngx July 14, 2022 23:43
ciarams87
ciarams87 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

pleshakov
pleshakov approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

however, an update to https://github.com/nginxinc/nginx-plus-go-client#compatibility is missing.
I also recommend specifying all supported versions, not just the latest one.

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 15, 2022
@lucacome lucacome requested a review from a team July 15, 2022 18:04
nginx-gists
nginx-gists reviewed Jul 15, 2022
View reviewed changes
Copy link

@nginx-gists nginx-gists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This client works against versions 4, 5, and 6 ...

@lucacome lucacome merged commit 43df4f7 into main Jul 15, 2022
@lucacome lucacome deleted the feat/api-v6 branch July 15, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-gists nginx-gists nginx-gists left review comments

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@jjngx jjngx Awaiting requested review from jjngx

Assignees

@lucacome lucacome

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for API version 6
5 participants
@lucacome @pleshakov @ciarams87 @nginx-gists @shaun-nx