-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature: Stats contain /nginx status info #12
Conversation
@jthurman42 thx for the PR. we'll review it shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed review. Please see my suggestions.
This also modified test.conf to allow API writes as required by the test framework. The existing limit_except config did not work testing on an AWS instance of nginx/1.15.2 (nginx-plus-r16-p1)
Are you running NGINX Plus on a VM, not in a container, right?
Yes, I've been testing with the Nginx Plus AWS AMI. Updated from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@jthurman42 thanks! please squash your commits into a single one and we'll merge it. |
Commits squashed. Thank you! |
Proposed changes
Include Nginx status information (
/api/<version>/nginx
endpoint) when calling GetStats. This metadata contains valuable metadata about the running instance.This also modified
test.conf
to allow API writes as required by the test framework. The existing limit_except config did not work testing on an AWS instance of nginx/1.15.2 (nginx-plus-r16-p1)Checklist
Before creating a PR, run through this checklist and mark each as complete.