Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key-value support #13

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Add key-value support #13

merged 1 commit into from
Dec 13, 2018

Conversation

isaachawley
Copy link
Contributor

@isaachawley isaachawley commented Dec 10, 2018 •
edited

Full support for key-value endpoints for both http and stream contexts.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@isaachawley isaachawley self-assigned this Dec 10, 2018
pleshakov
pleshakov requested changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions

client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Show resolved Hide resolved
client/nginx.go Show resolved Hide resolved
client/nginx.go Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Show resolved Hide resolved
tests/client_test.go Outdated Show resolved Hide resolved
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Dec 11, 2018
pleshakov
pleshakov requested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions

client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
tests/client_test.go Outdated Show resolved Hide resolved
tests/client_test.go Outdated Show resolved Hide resolved
tests/client_test.go Outdated Show resolved Hide resolved
@isaachawley isaachawley force-pushed the add-key-value branch 2 times, most recently from 3c32468 to 66e09b0 Compare December 12, 2018 17:46
pleshakov
pleshakov requested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions

client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
@isaachawley isaachawley force-pushed the add-key-value branch 3 times, most recently from 88ea99b to 93e899a Compare December 13, 2018 14:53
Add key-value support
299a879 
Full support for key-value endpoints for both http and stream contexts.
@isaachawley isaachawley merged commit c5dd478 into master Dec 13, 2018
@isaachawley isaachawley deleted the add-key-value branch December 13, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees

@isaachawley isaachawley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaachawley @pleshakov @Dean-Coakley