Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extended SSL stats #184

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update extended SSL stats #184

merged 2 commits into from
Nov 9, 2023

Conversation

dakshinai
Copy link
Contributor

@dakshinai dakshinai commented Nov 6, 2023 •
edited

Proposed changes

This PR addresses #183 to include extended SSL stats added since N+ R28

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@dakshinai dakshinai requested a review from a team as a code owner November 6, 2023 19:39
@dakshinai dakshinai marked this pull request as draft November 6, 2023 20:23
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 7, 2023
@dakshinai dakshinai force-pushed the r28-extended-ssl-stats branch 3 times, most recently from 35db279 to 41d3908 Compare November 7, 2023 17:44
@github-actions github-actions bot removed the tests Pull requests that update tests label Nov 7, 2023
@dakshinai dakshinai force-pushed the r28-extended-ssl-stats branch 3 times, most recently from 1936719 to 0638380 Compare November 7, 2023 18:50
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 7, 2023
@github-actions github-actions bot removed the tests Pull requests that update tests label Nov 7, 2023
@dakshinai dakshinai marked this pull request as ready for review November 7, 2023 19:08
jjngx
jjngx approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

@jjngx jjngx requested a review from a team November 8, 2023 15:10
@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Nov 8, 2023
@dakshinai
Copy link
Contributor Author

Thank you for the reviews, is this good to merge?

@shaun-nx shaun-nx merged commit 6be5938 into nginxinc:main Nov 9, 2023
19 checks passed
@shaun-nx
Copy link

shaun-nx commented Nov 9, 2023

Thanks @dakshinai ! 🎉

@shaun-nx shaun-nx linked an issue Nov 9, 2023 that may be closed by this pull request
Request for extended SSL stats added since N+ R28 #183
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for extended SSL stats added since N+ R28
4 participants
@dakshinai @shaun-nx @ciarams87 @jjngx