Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone sync endpoint to stats #20

Merged
merged 1 commit into from
May 29, 2019
Merged

Add zone sync endpoint to stats #20

merged 1 commit into from
May 29, 2019

Conversation

Rulox
Copy link

@Rulox Rulox commented May 27, 2019

Proposed changes

Add Stream Zone Sync (http://nginx.org/en/docs/http/ngx_http_api_module.html#def_nginx_stream_zone_sync) metrics in the client.

@Rulox
Copy link
Author

Rulox commented May 28, 2019

@pleshakov I have added tests. Summary:

  • Create a new NGINX Plus instance for tests
  • Add a new key-val pair to the first instance
  • Add tests that check both instances sync zones

Note: The sync between the zones take some time, I've been doing some tests and a sleep of 5 seconds is needed so the API returns valid values.

Please let me know what you think, thanks!

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit da159e5 into master May 29, 2019
@Rulox Rulox deleted the zone-sync-support branch May 29, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants