Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestStatsNoStream #224

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Fix TestStatsNoStream #224

merged 3 commits into from
Feb 29, 2024
+3 −3

Conversation

dhurley
Copy link
Contributor

@dhurley dhurley commented Feb 8, 2024

Proposed changes

This PR should resolve the issue reported here: #216

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@dhurley dhurley requested a review from a team as a code owner February 8, 2024 10:15
@github-actions github-actions bot added the tests Pull requests that update tests label Feb 8, 2024
@github-actions github-actions bot removed the tests Pull requests that update tests label Feb 22, 2024
@ciarams87 ciarams87 merged commit a675f7d into nginxinc:main Feb 29, 2024
12 checks passed
@ciarams87 ciarams87 linked an issue Feb 29, 2024 that may be closed by this pull request
TestStatsNoStream is failing #216
Closed
@lucacome lucacome added the tests Pull requests that update tests label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestStatsNoStream is failing
5 participants
@dhurley @sjberman @ciarams87 @vepatel @lucacome