Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added context timeout configuration for API requests #331

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Add the ability to configure the context timeout period for API requests. Currently it is hardcoded to 10 seconds. Added a configuration parameter to override this value.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oliveromahony oliveromahony requested a review from a team as a code owner July 25, 2024 15:21
@sjberman
Copy link

Looks like this can close #205

@oliveromahony
Copy link
Contributor Author

oliveromahony commented Jul 25, 2024

Looks like this can close #205

I don't believe it can. I think in that case, you would have to extend the client calls to have a context parameter that can be passed. That is a far bigger change than this PR. This only allows the consumer of this client to add their own configuration setting.

@sjberman
Copy link

I guess that's true...if you want the granularity of a per-call timeout, then this doesn't satisfy that.

@oliveromahony oliveromahony merged commit b02c7a8 into nginxinc:main Jul 26, 2024
13 checks passed
@oliveromahony oliveromahony deleted the add-configurable-timeout branch July 26, 2024 08:43
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants