Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to get /slabs #38

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

faisal-memon
Copy link
Contributor

@faisal-memon faisal-memon commented Jan 10, 2020

Proposed changes

Adding support for /slabs API endpoint so we can monitor shared memory zone usage.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox requested review from Rulox, Dean-Coakley and pleshakov and removed request for Rulox January 13, 2020 10:38
client/nginx.go Outdated Show resolved Hide resolved
@Rulox
Copy link

Rulox commented Jan 13, 2020

lgtm, a small suggestion on a error string and :shipit: !

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jan 13, 2020
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @faisal-memon !
👍

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faisal-memon !

In a separate PR I'd like:

func TestStats(t *testing.T) {
to be extended to include some basic test coverage of slabs & slots stats.

Let us know if you want to add it. - If not, we'll add it.

@Dean-Coakley Dean-Coakley merged commit f60536a into nginxinc:master Jan 14, 2020
@Dean-Coakley Dean-Coakley mentioned this pull request Jan 20, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants