Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of N+ API version 4 #54

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add support of N+ API version 4 #54

merged 1 commit into from
Nov 26, 2020

Conversation

framer777
Copy link
Contributor

@framer777 framer777 commented Nov 23, 2020 •
edited

Proposed changes

Add support of NGINX PLUS API version 4 for N+ R18 and earlier.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have rebased my branch onto master

@framer777 framer777 force-pushed the add-v4-support branch 3 times, most recently from 1acf13c to be1affc Compare November 23, 2020 18:22
mikestephen
mikestephen reviewed Nov 24, 2020
View reviewed changes
Copy link

@mikestephen mikestephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some duplicated code could be removed I think?

client/nginx.go Outdated Show resolved Hide resolved
@framer777 framer777 force-pushed the add-v4-support branch 3 times, most recently from 5bb5db3 to ed11cba Compare November 24, 2020 17:37
Dean-Coakley
Dean-Coakley approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💨

client/nginx.go Show resolved Hide resolved
@framer777 framer777 changed the title WIP: Add support of N+ API version 4 Add support of N+ API version 4 Nov 24, 2020
@framer777 framer777 merged commit e2a341d into master Nov 26, 2020
@framer777 framer777 deleted the add-v4-support branch November 26, 2020 20:01
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@mikestephen mikestephen mikestephen approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@framer777 @mikestephen @Dean-Coakley @lucacome