Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache stats #69

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Add cache stats #69

merged 1 commit into from
Jun 7, 2021

Conversation

jac
Copy link
Contributor

@jac jac commented Jun 4, 2021

Retrieves cache stats from the http/caches endpoint

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Dean-Coakley
Dean-Coakley approved these changes Jun 4, 2021
View reviewed changes
client/nginx.go Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jac , just a few suggestions

client/nginx.go Outdated Show resolved Hide resolved
client/nginx.go Outdated Show resolved Hide resolved
pleshakov
pleshakov approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good to me!
We need one more approval from the team member. Sorry for the bureaucracy :)

@lucacome lucacome merged commit da5dbf7 into nginxinc:master Jun 7, 2021
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@soneillf5 soneillf5 Awaiting requested review from soneillf5

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jac @lucacome @pleshakov @Dean-Coakley