Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile, NGINX and golangci-lint versions #70

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Update Dockerfile, NGINX and golangci-lint versions #70

merged 1 commit into from
Jun 21, 2021

Conversation

lucacome
Copy link
Member

  • Update NGINX Plus to R24
  • Updated Docker base image to buster
  • Mount nginx cert and key at build time instead of copying into the container
  • Updated golangci-lint to use latest

@lucacome lucacome requested a review from a team June 17, 2021 22:42
@lucacome lucacome self-assigned this Jun 17, 2021
@lucacome lucacome requested review from ciarams87 and soneillf5 and removed request for a team June 17, 2021 22:42
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 17, 2021
@lucacome lucacome added the dependencies Pull requests that update a dependency file label Jun 17, 2021
soneillf5
soneillf5 reviewed Jun 18, 2021
View reviewed changes
docker/Dockerfile

EXPOSE 80

STOPSIGNAL SIGTERM
STOPSIGNAL SIGQUIT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because nginx is the running process and SIGQUIT is the right signal to stop nginx 😬

@lucacome lucacome merged commit d3afe3b into master Jun 21, 2021
@lucacome lucacome deleted the chore/update-nginx-ci branch June 21, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soneillf5 soneillf5 soneillf5 approved these changes

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @pleshakov @soneillf5