Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build client and test on scheduled runs #74

Merged
merged 1 commit into from
Jun 25, 2021
Merged

chore: build client and test on scheduled runs #74

merged 1 commit into from
Jun 25, 2021

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Jun 22, 2021 •
edited

Proposed changes

Build client stage wasn't running on nightly as scheduled events weren't one of the conditions

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 22, 2021
@ciarams87 ciarams87 requested a review from soneillf5 June 23, 2021 08:31
@ciarams87 ciarams87 merged commit 80ef05b into master Jun 25, 2021
@ciarams87 ciarams87 deleted the chore/fix-nightly-schedule branch June 25, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 Awaiting requested review from soneillf5

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciarams87 @lucacome @pleshakov