Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make default NGINX Plus Dockerfile use buildkit #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jun 25, 2024

Proposed changes

This PR refactors the NGINX Plus Dockerfile makes the Buildkit Dockerfile the default NGINX Plus build given that both Buildkit is now the default Docker engine and that using Buildkit is a better build option security (and in doing so remove the current existing default Plus Dockerfile).

Part of this original commit has been split into a different PR #274.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@alessfg alessfg requested a review from 4141done June 25, 2024 21:14
@alessfg alessfg self-assigned this Jun 25, 2024
@alessfg alessfg added bug Something isn't working enhancement New feature or request labels Jun 25, 2024
@alessfg alessfg changed the title fix: update NGINX Plus Dockerfile feat: make default NGINX Plus Dockerfile use buildkit Jun 26, 2024
@alessfg alessfg force-pushed the dockerfile-updates branch from 93234cc to b3c7433 Compare June 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant