Revert Go version to 1.22.0 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a library so it will be compiled with the version specified in the project that imports it. This also is treated by Go as a minimum suggested version and we should only increase it if we need new features from the language. Bumping this to the latest version only means that the projects importing it will be forced to update to the same version.
github-actions
bot
added
chore
lucacome
force-pushed
the
chore/revert-go-update
branch
from
8b64ade
to
2e3b2a3
Compare
sjberman
approved these changes
Jun 5, 2024
|
That fix security issues we should not revert it. https://go.dev/doc/devel/release#go1.22.4 |
| @@ -1,6 +1,6 @@ | |||
| module github.com/nginxinc/telemetry-exporter | |||
|
|
|||
| go 1.22.4 | |||
There was a problem hiding this comment.
Resolving after internal discussion on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is a library so it will be compiled with the version specified in the project that imports it. This also is treated by Go as a minimum suggested version and we should only increase it if we need new features from the language. Bumping this to the latest version only means that the projects importing it will be forced to update to the same version.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide