-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional test #26
Conversation
39770fb
to
e8dc6e7
Compare
forced pushed because of the rebase and conflict resolving of go.mod and go.sum files |
f275f73
to
8274462
Compare
forced push to resolved conflicts in Makefile after merging #20 |
ca77cce
to
fb1fba2
Compare
@ciarams87 could you possibly double check these commits https://github.com/nginxinc/telemetry-exporter/pull/26/files/8274462eaf00342cf9a2cd8ec171aeb30a8ae373..fb1fba20f17e32957b3df33ef4a2f1e7407e2e9e - those were the results of merging Luca suggestions |
That looks fine. One non-blocking suggestion around uploading both unit-test coverage reports, otherwise looks good! |
Problem: Ensure the exporter library correctly sends telemetry data via OTel Solution: Add a functional test: - Exporter sends telemetry data to an OTel collector - Ensure the collector successfully receives the data by looking at its logs - Include the test into GitHub pipeline. CLOSES #7
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
Co-authored-by: Saylor Berman <s.berman@f5.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
e9964b4
to
8d09c36
Compare
Proposed changes
Problem:
Ensure the exporter library correctly sends telemetry data via OTel
Solution:
Add a functional test:
CLOSES #7
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide