Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional test #26

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Add functional test #26

merged 8 commits into from
Mar 6, 2024

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:
Ensure the exporter library correctly sends telemetry data via OTel

Solution:
Add a functional test:

  • Exporter sends telemetry data to an OTel collector
  • Ensure the collector successfully receives the data by looking at its logs
  • Include the test into GitHub pipeline.

CLOSES #7

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING
    guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@pleshakov pleshakov requested a review from a team as a code owner February 26, 2024 15:48
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tests Pull requests that update tests labels Feb 26, 2024
@nginxinc nginxinc deleted a comment from github-actions bot Feb 26, 2024
ciarams87
ciarams87 reviewed Feb 29, 2024
View reviewed changes
tests/exporter_test.go Outdated Show resolved Hide resolved
tests/exporter_test.go Outdated Show resolved Hide resolved
tests/exporter_test.go Outdated Show resolved Hide resolved
@pleshakov
Copy link
Contributor Author

forced pushed because of the rebase and conflict resolving of go.mod and go.sum files

sjberman
sjberman reviewed Feb 29, 2024
View reviewed changes
tests/exporter_test.go Outdated Show resolved Hide resolved
tests/exporter_test.go Show resolved Hide resolved
@pleshakov
Copy link
Contributor Author

forced push to resolved conflicts in Makefile after merging #20

lucacome
lucacome reviewed Feb 29, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
tests/Dockerfile Show resolved Hide resolved
@pleshakov
Copy link
Contributor Author

@ciarams87 could you possibly double check these commits https://github.com/nginxinc/telemetry-exporter/pull/26/files/8274462eaf00342cf9a2cd8ec171aeb30a8ae373..fb1fba20f17e32957b3df33ef4a2f1e7407e2e9e - those were the results of merging Luca suggestions

ciarams87
ciarams87 reviewed Mar 6, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ciarams87
Copy link
Member

@ciarams87 could you possibly double check these commits https://github.com/nginxinc/telemetry-exporter/pull/26/files/8274462eaf00342cf9a2cd8ec171aeb30a8ae373..fb1fba20f17e32957b3df33ef4a2f1e7407e2e9e - those were the results of merging Luca suggestions

That looks fine. One non-blocking suggestion around uploading both unit-test coverage reports, otherwise looks good!

pleshakov and others added 8 commits March 6, 2024 09:26
@pleshakov
Add functional test
ccacefc 
Problem:
Ensure the exporter library correctly sends telemetry data via OTel

Solution:
Add a functional test:
- Exporter sends telemetry data to an OTel collector
- Ensure the collector successfully receives the data by looking at
its logs
- Include the test into GitHub pipeline.

CLOSES #7
@pleshakov @ciarams87
Apply suggestions from code review
c658504 
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
@pleshakov @sjberman
Update tests/exporter_test.go
893f76b 
Co-authored-by: Saylor Berman <s.berman@f5.com>
@pleshakov @lucacome
Update Makefile
0fb6c8e 
Co-authored-by: Luca Comellini <luca.com@gmail.com>
@pleshakov @lucacome
Update Makefile
3c657c5 
Co-authored-by: Luca Comellini <luca.com@gmail.com>
@pleshakov
Fix Makefile
b5bf0c3
@pleshakov
Update ci for cover.html
fea9eaa
@pleshakov @ciarams87
Update .github/workflows/ci.yml
8d09c36 
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
@pleshakov pleshakov merged commit e74e64e into main Mar 6, 2024
11 checks passed
@pleshakov pleshakov deleted the test/collector branch March 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome left review comments

@ciarams87 ciarams87 ciarams87 approved these changes

@sjberman sjberman sjberman approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functional test
5 participants
@pleshakov @ciarams87 @lucacome @sjberman @jjngx