Fix missing attribute sent along with the data #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: F5 telemetry service requires the dataType attribute present, which must be equal to the `@df_datatype` annotation in the scheme. Solution: Add dataType attribute to the generated Attributes() method. Note: the attribute only required for the struct for which we generate the scheme. In the Attribute() method of any embedded structs, dataType attribute must not be set. CLOSES #39
sjberman
reviewed
Mar 6, 2024
sjberman
approved these changes
Mar 6, 2024
kate-osborn
approved these changes
Mar 6, 2024
shaun-nx
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
F5 telemetry service requires the dataType attribute present, which must be equal to the
@df_datatypeannotation in the scheme.Solution:
Add dataType attribute to the generated Attributes() method.
Note: the attribute only required for the struct for which we generate the scheme. In the Attribute() method of any embedded structs, dataType attribute must not be set.
CLOSES #39
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide