Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of local import #117

Open
unode opened this issue Aug 12, 2019 · 1 comment
Open

Inconsistent use of local import #117

unode opened this issue Aug 12, 2019 · 1 comment
Labels

Comments

@unode
Copy link
Member

unode commented Aug 12, 2019

This was noticed when setting up the motus ngless-contrib module.

The following ngless script runs fine, but I'm not sure it should:

ngless "1.0"
import "motus" version "2.1"

In particular because version 2.1 is not an internal module meaning it should require the local keyword.

Trying to use any of the other modules in ngless-contrib without the local keyword triggers the To import local modules, use "local import" error.

My understanding is that since motus also exists as an internal module (version 1.0) the local keyword check is bypassed.

@unode
Copy link
Member Author

unode commented Oct 4, 2019

A recent discussion on ngless mailing list reports an error with ngless trying to download motus 2.5 from the official resources website.

Exiting after fatal error while loading and running script
System Error
Could not connect to https://ngless.embl.de/resources/Modules/motus.ngm/2.5.tar.gz (got error code: 404)

Upgrading this report to bug.

The code should validate not just the module name but also that the version is a builtin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant