Update package.json

[jan-janssen]

Fix jupyterlab compatibility

[jan-janssen]

The same is discussed here jupyterlab/jupyterlab#2707

[hainm]

thanks @jan-janssen. I am not sure why NGL was deleted from requirement.

[jan-janssen]

If there is any chance to update the requirements on conda-forge/ pip that would be perfect for me.

[hainm]

what do you mean? ngl is packed with nglview for each release.
https://github.com/arose/nglview/tree/master/nglview/static

[jan-janssen]

ok, I did not know that - thanks a lot.

[jan-janssen]

But the package at https://www.npmjs.com/package/nglview-js-widgets still contains the old code - can you update the requirements there, to fix the issues with the conda installation?

[hainm]

Hi, why do you need nglview-js-widgets? I don’t think it has anything with conda.

…

On Mon, Aug 6, 2018 at 4:27 AM Jan Janßen ***@***.***> wrote: But the package at https://www.npmjs.com/package/nglview-js-widgets still contains the old code - can you update the requirements there, to fix the issues with the conda installation? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#746 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEPudb64OvMcz8AUo6UJu8uI0ZgdQJfAks5uN_3jgaJpZM4VvWf7> .

[jan-janssen]

Basically what I want is to run conda install nglview and that should already configure jupyterlab to work with nglview. For now this requires the following additional steps:

jupyter labextension install @jupyter-widgets/jupyterlab-manager --no-build
git clone https://github.com/arose/nglview.git ~/nglview
jupyter labextension install ~/nglview/js --no-build
jupyter lab build
rm -rf ~/nglview

https://github.com/pyiron/pyiron-mybinder/blob/master/binder/postBuild

simply because jupyter labextension install nglview-js-widgets does not work. Maybe the easiest way would be to have an additional package named nglviewlab or so, which runs the installation of the widgets after the setup of nglview.

[hainm]

Basically what I want is to run conda install nglview and that should already configure jupyterlab to work with nglview.

ha, this is new. Does that work because of the new notebook or jupyterlab verison? I recall that I need to perform a bunch of steps to make nglview work with jupyterlab.

simply because jupyter labextension install nglview-js-widgets does not work.

Can you elaborate this?
PS: I have a script to make nglview work with specific lab version. https://github.com/arose/nglview/blob/master/devtools/nglview-jupyterlab.sh

[jan-janssen]

I basically spend my weekend on this, but now nglview is working with mybinder.org (what we discussed in #736 ). You can try it with https://github.com/pyiron/pyiron-mybinder and I also build a docker image working with NGLview in Jupyterlab https://github.com/pyiron/pyiron-docker/blob/lab/Dockerfile but at the moment both require the workaround I posted above, so I would like to move this to the post build script of the conda installation, but for this somebody needs to update the nglview-js-widgets package on npm.

[hainm]

thanks for let us know, but I really need to know why below

simply because jupyter labextension install nglview-js-widgets does not work. Does lab raise error, or nothing is shown up in lab or anything else?

[hainm]

You can try it with https://github.com/pyiron/pyiron-mybinder

Nice. It would be great if it's easier to find the notebooks.

[jan-janssen]

Without the requirement the jupyterlab build fails, webpack is not able to find ngl as dependency of nglview-js-widgets therefore the plugin can not be installed/enabled. As for the binder example - thank you for the feedback - we have to place the notebooks in the root directory, but the same examples are also used in other repositories so it is not so easy (I am working on it). Still it might be also a nice demo for nglview to add an jupyterlab demonstration on mybinder.

[jan-janssen]

I added a pull request for the nglview notebooks repository as well arose/nglview-notebooks#2 which includes the jupyterlab config for mybinder.