Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.1.8 #772

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Update to 1.1.8 #772

merged 2 commits into from
Feb 21, 2019

Conversation

jan-janssen
Copy link
Contributor

Similar to - but this time from 1.1.7 to 1.1.8
#749

This should enable nglview 1.1.8 to work with jupyter lab.

@hainm hainm merged commit 6833294 into nglviewer:master Feb 21, 2019
@hainm
Copy link
Collaborator

hainm commented Feb 21, 2019

thanks @jan-janssen

@hainm
Copy link
Collaborator

hainm commented Feb 21, 2019

uhm, I reverted your change in bfdaaf1 since it introduced back the NGL 2.0.0-dev0.0. The version has the fix for unitcell is 2.0.0-dev0.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants