Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OpenGraph and Twitter attributes to header #476

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

IdanCo
Copy link
Contributor

@IdanCo IdanCo commented Aug 7, 2023

This update includes OpenGraph and Twitter attributes in the HTML header. This enhances sharing experiences on social media. Shared content now presents more rich and relevant information.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

As can be seen here, sharing Elf's url does not look good -
image

What is the new behavior?

When this changes are deployed, sharing Elf would look like this -

image

Does this PR introduce a breaking change?

[ ] Yes
[ X] No

Other information

This update includes OpenGraph and Twitter attributes in the HTML header.
This enhances sharing experiences on social media.
Shared content now presents more rich and relevant information.
@stackblitz
Copy link

stackblitz bot commented Aug 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit 0944af2 into ngneat:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants