feat: update to Angular 19 #200
Conversation
Changes that were applied: - bump dependency versions - applied migrations from `migrations.json` - remove unused component imports - add `as unknown` to `updateOptions` to fix a previously working type conversion - add `skipToken` check to `normalizeOptions` to narrow down typing
|
|
| @@ -166,7 +166,7 @@ export function createBaseQuery< | |||
| ...newOptions, | |||
| }, | |||
| injector, | |||
| ) as QueryObserverOptions< | |||
| ) as unknown as QueryObserverOptions< | |||
There was a problem hiding this comment.
@NetanelBasal dont know if this can be changed in a reasonable way, but it complained about an incompatibility on TQueryKey which suddenly was TQueryKey & {} (which is weird since its always a ReadonlyArray<unknown>, and this type only says that it should filter out null and undefined values - atleast this is what & {} does since i last checked)
|
Got an issue after installed https://github.com/angular /code@19.0.5 npm warn Could not resolve dependency: |
try downgrading to angular version 19.0.4. |
Changes that were applied:
migrations.jsonas unknowntoupdateOptionsto fix a previously working type conversionskipTokencheck tonormalizeOptionsto narrow down typingPR Checklist
Please check if your PR fulfills the following requirements:
No addidtional changes were made
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #199
What is the new behavior?
Does this PR introduce a breaking change?
Other information
There is a type conversion that previously was working in
updateOptions, now i addedas unknownto it to make it work again. Linting and testing did work out of the box, so no changes were made here. Only building had the error on top and theskipTokencheck, since now thequeryFnhas aunique symbolas additional type on it, for that reason i added the check on it to filter out the symbol and return the default options. So maybe it would be good if you can check what i did @NetanelBasal and if everything checks out to your liking