Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

bump libs for WebVR API v1.0 #796

Closed
wants to merge 1 commit into from
Closed

bump libs for WebVR API v1.0 #796

wants to merge 1 commit into from

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Feb 26, 2016

@@ -14,7 +14,7 @@
"style-attr": "^1.0.1",
"three-dev": "^0.74.0-beta8",
"tween.js": "^15.0.0",
"webvr-polyfill": "borismus/webvr-polyfill#3f47796"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when this is merged upstream, we'll point back to boris'

@cvan
Copy link
Contributor Author

cvan commented Feb 29, 2016

@ngokevin @dmarcos can we merge?

@cvan cvan self-assigned this Feb 29, 2016
@cvan
Copy link
Contributor Author

cvan commented Mar 1, 2016

I want to merge this, but it looks like Brandon's still got several bugs to address with webvr-polyfill and THREE.VREffect.

Using the latest Oculus Chromium build, scenes using THREE.VREffect do not render correctly in the Oculus headset. See my comment in Brandon's PR: mrdoob/three.js#8221 (comment) In the headset, the image appears super enlarged. I tried the webvr_cubes three.js WebVR example (http://threejs.org/examples/#webvr_cubes) with Brandon's branch, and I couldn't get the scene to render correctly. I also tried hooking it up to Sechelt and A-Frame scenes - same issue. It might be worth adding a three.js WebVR scene to Brandon's webvr-samples repo. (I filed https://github.com/toji/webvr-samples/issues/13 to add a three.js test scene.)

The changes to THREE.VREffect in the PR currently do not work in Firefox (nor in the deprecated Chromium WebVR builds, but I know that's not an issue). See my comment here: mrdoob/three.js#8221 (comment)

The changes to webvr-polyfill in the PR currently do not work in Firefox (nor in the deprecated Chromium WebVR builds, but I know that's not an issue). See my comment here: immersive-web/webvr-polyfill#33 (comment)

Also, looks like Brandon's making some changes directly to webvr-polyfill in the webvr-samples directory.

@ngokevin
Copy link
Owner

ngokevin commented Mar 1, 2016

Should we bother merging this for 0.1.x?

@cvan
Copy link
Contributor Author

cvan commented Mar 1, 2016

Should we bother merging this for 0.1.x?

well, all A-Frame sites don't/won't work in the Chromium builds. so I think we should.

@cvan cvan removed their assignment Apr 27, 2016
@ngokevin ngokevin closed this Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants