-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to style the container of the text View. #3
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
@@ -41,4 +45,5 @@ import AutoTypingText from 'react-native-auto-typing-text'; | |||
|**`charMovingTime`**|`number`|time to type each character| | |||
|**`delay`**|`number`|Delay time before typing| | |||
|**`style`**|`string`|Style for text| | |||
|**`containerStyle`**|`string`|Style for text container| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
containerStyle
must be object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that may more sense but tried to match the previous, i'll make the change now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I thought u copy pasted as it was same 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it, change this too. It should be a number
not string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry didn't see that I'll add another commit
README.md
Outdated
@@ -41,4 +45,5 @@ import AutoTypingText from 'react-native-auto-typing-text'; | |||
|**`charMovingTime`**|`number`|time to type each character| | |||
|**`delay`**|`number`|Delay time before typing| | |||
|**`style`**|`string`|Style for text| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style
must be object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now good to go 🎉 🎉
@deadcoder0904 just wondering if we can drop the HiddenText.js completely not sure of it's use? |
Naah I guess |
@deadcoder0904 yes, that's right. It's the purpose of |
Great 👍 @ngothanhtai this good to be pulled in? |
<View style={[styles.flex1]}> | ||
<Text { ...this.props }> | ||
<View style={this.props.containerStyle}> | ||
<Text style={this.props.style}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackThomson2 some props (selectable
, accessible
, etc.), users need to pass to the Text
component so I prefer to keep { ...this.props }
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackThomson2 just give you a comment. please kindly review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure no problem I'll make the change when I get a chance 👍
The changes shouldn't break existing code.