Add the option to style the container of the text View. #3
Conversation
README.md
Outdated
| @@ -41,4 +45,5 @@ import AutoTypingText from 'react-native-auto-typing-text'; | |||
| |**`charMovingTime`**|`number`|time to type each character| | |||
| |**`delay`**|`number`|Delay time before typing| | |||
| |**`style`**|`string`|Style for text| | |||
| |**`containerStyle`**|`string`|Style for text container| | |||
There was a problem hiding this comment.
I thought that may more sense but tried to match the previous, i'll make the change now
There was a problem hiding this comment.
Yep, I thought u copy pasted as it was same 😂
There was a problem hiding this comment.
While you are at it, change this too. It should be a number not string
There was a problem hiding this comment.
Oops sorry didn't see that I'll add another commit
README.md
Outdated
| @@ -41,4 +45,5 @@ import AutoTypingText from 'react-native-auto-typing-text'; | |||
| |**`charMovingTime`**|`number`|time to type each character| | |||
| |**`delay`**|`number`|Delay time before typing| | |||
| |**`style`**|`string`|Style for text| | |||
|
@deadcoder0904 just wondering if we can drop the HiddenText.js completely not sure of it's use? |
|
Naah I guess |
|
@deadcoder0904 yes, that's right. It's the purpose of |
|
Great 👍 @ngothanhtai this good to be pulled in? |
| <View style={[styles.flex1]}> | ||
| <Text { ...this.props }> | ||
| <View style={this.props.containerStyle}> | ||
| <Text style={this.props.style}> |
There was a problem hiding this comment.
@JackThomson2 some props (selectable, accessible, etc.), users need to pass to the Text component so I prefer to keep { ...this.props }.
There was a problem hiding this comment.
@JackThomson2 just give you a comment. please kindly review :)
There was a problem hiding this comment.
Oh sure no problem I'll make the change when I get a chance 👍
The changes shouldn't break existing code.