Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use last column to parse remote address #31

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use last column to parse remote address #31

merged 1 commit into from
Oct 20, 2023

Conversation

nikolay-ngrok
Copy link
Contributor

Resolves: #30

Use the last column to split host/port, instead of the first one, which fails in case of ipv6 address.

@nikolay-ngrok nikolay-ngrok mentioned this pull request Oct 19, 2023
Closed
@nikolay-ngrok nikolay-ngrok self-assigned this Oct 19, 2023
bobzilladev
bobzilladev approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolay-ngrok nikolay-ngrok merged commit e8e99f7 into main Oct 20, 2023
4 checks passed
@nikolay-ngrok nikolay-ngrok deleted the nikolay/remote-addr-parse branch October 20, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzilladev bobzilladev bobzilladev approved these changes

Assignees

@nikolay-ngrok nikolay-ngrok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection.inetAddress() fails for IPv6 addresses
2 participants
@nikolay-ngrok @bobzilladev