fix(component-store): applying changes due to code review

ngrx · Jun 17, 2024 · 252f677 · 252f677
1 parent 845f117
commit 252f677
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/modules/component-store/migrations/18_0_0-beta/index.spec.ts b/modules/component-store/migrations/18_0_0-beta/index.spec.ts
@@ -208,7 +208,7 @@ class SomeEffects {}
     expect(logEntries[0]).toMatchObject({
       message:
         '[@ngrx/component-store] Skipping because of multiple `tapResponse` imports',
-      level: 'warn',
+      level: 'info',
     });
   });
 

diff --git a/modules/component-store/migrations/18_0_0-beta/index.ts b/modules/component-store/migrations/18_0_0-beta/index.ts
@@ -14,7 +14,6 @@ import {
   visitTSSourceFiles,
 } from '../../schematics-core';
 import { createRemoveChange } from '../../schematics-core/utility/change';
-import * as os from 'node:os';
 
 export function migrateTapResponseImport(): Rule {
   return (tree: Tree, ctx: SchematicContext) => {
@@ -47,7 +46,7 @@ export function migrateTapResponseImport(): Rule {
       if (componentStoreImportsAndDeclarations.length === 0) {
         return;
       } else if (componentStoreImportsAndDeclarations.length > 1) {
-        ctx.logger.warn(
+        ctx.logger.info(
           '[@ngrx/component-store] Skipping because of multiple `tapResponse` imports'
         );
         return;
@@ -125,7 +124,7 @@ export function migrateTapResponseImport(): Rule {
           new InsertChange(
             sourceFile.fileName,
             componentStoreImportDeclaration.getEnd() + 1,
-            `${newOperatorsImport}${os.EOL}`
+            `${newOperatorsImport}\n` // not os-independent for snapshot tests
           )
         );
       }