refactor(example): refactor effects ofType (#1462)

ngrx · Dec 12, 2018 · ab494b1 · ab494b1
1 parent 9b3c75b
commit ab494b1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 14 deletions.
diff --git a/projects/example-app/src/app/auth/effects/auth.effects.ts b/projects/example-app/src/app/auth/effects/auth.effects.ts
@@ -17,7 +17,7 @@ import { LogoutConfirmationDialogComponent } from '@example-app/auth/components/
 export class AuthEffects {
   @Effect()
   login$ = this.actions$.pipe(
-    ofType<LoginPageActions.Login>(LoginPageActions.LoginPageActionTypes.Login),
+    ofType(LoginPageActions.LoginPageActionTypes.Login),
     map(action => action.payload.credentials),
     exhaustMap((auth: Credentials) =>
       this.authService.login(auth).pipe(
@@ -65,7 +65,7 @@ export class AuthEffects {
   );
 
   constructor(
-    private actions$: Actions,
+    private actions$: Actions<LoginPageActions.LoginPageActionsUnion>,
     private authService: AuthService,
     private router: Router,
     private dialog: MatDialog

diff --git a/projects/example-app/src/app/books/effects/book.effects.ts b/projects/example-app/src/app/books/effects/book.effects.ts
@@ -12,7 +12,10 @@ import {
 } from 'rxjs/operators';
 
 import { GoogleBooksService } from '@example-app/core/services/google-books.service';
-import { BooksApiActions, FindBookPageActions } from '@example-app/books/actions';
+import {
+  BooksApiActions,
+  FindBookPageActions,
+} from '@example-app/books/actions';
 import { Book } from '@example-app/books/models/book';
 
 /**
@@ -33,9 +36,7 @@ export class BookEffects {
     Action
   > =>
     this.actions$.pipe(
-      ofType<FindBookPageActions.SearchBooks>(
-        FindBookPageActions.FindBookPageActionTypes.SearchBooks
-      ),
+      ofType(FindBookPageActions.FindBookPageActionTypes.SearchBooks),
       debounceTime(debounce, scheduler),
       map(action => action.payload),
       switchMap(query => {
@@ -57,7 +58,7 @@ export class BookEffects {
     );
 
   constructor(
-    private actions$: Actions,
+    private actions$: Actions<FindBookPageActions.FindBookPageActionsUnion>,
     private googleBooks: GoogleBooksService
   ) {}
 }
diff --git a/projects/example-app/src/app/books/effects/collection.effects.ts b/projects/example-app/src/app/books/effects/collection.effects.ts
@@ -47,9 +47,7 @@ export class CollectionEffects {
 
   @Effect()
   addBookToCollection$: Observable<Action> = this.actions$.pipe(
-    ofType<SelectedBookPageActions.AddBook>(
-      SelectedBookPageActions.SelectedBookPageActionTypes.AddBook
-    ),
+    ofType(SelectedBookPageActions.SelectedBookPageActionTypes.AddBook),
     map(action => action.payload),
     mergeMap(book =>
       this.db.insert('books', [book]).pipe(
@@ -61,9 +59,7 @@ export class CollectionEffects {
 
   @Effect()
   removeBookFromCollection$: Observable<Action> = this.actions$.pipe(
-    ofType<SelectedBookPageActions.RemoveBook>(
-      SelectedBookPageActions.SelectedBookPageActionTypes.RemoveBook
-    ),
+    ofType(SelectedBookPageActions.SelectedBookPageActionTypes.RemoveBook),
     map(action => action.payload),
     mergeMap(book =>
       this.db.executeWrite('books', 'delete', [book.id]).pipe(
@@ -73,5 +69,10 @@ export class CollectionEffects {
     )
   );
 
-  constructor(private actions$: Actions, private db: Database) {}
+  constructor(
+    private actions$: Actions<
+      SelectedBookPageActions.SelectedBookPageActionsUnion
+    >,
+    private db: Database
+  ) {}
 }