Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematics: Update default action/reducer/effect template to be less generic #1040

Closed
brandonroberts opened this issue May 9, 2018 · 2 comments
Closed

Schematics: Update default action/reducer/effect template to be less generic #1040

brandonroberts opened this issue May 9, 2018 · 2 comments
Labels
6.x Project: Schematics

Comments

@brandonroberts
Copy link
Member

brandonroberts commented May 9, 2018 •
edited
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

What is the current behavior?

Expected behavior:

Minimal reproduction of the problem with instructions:

Version of affected browser(s),operating system(s), npm, node and ngrx:

Other information:

Right now the templates for a generated action blueprint are very generic (e.g.) [User] Action. This should be updated to be less generic and more usable out of the box. We should extend this to the reducer and effects also when generating a feature.

export enum UserActionTypes {
  LoadUsers = '[User] Load Users'
}

export class LoadUsers implements Action {
  readonly type = UserActionTypes.LoadUsers;
}

export type UserActions = LoadUsers;
@brandonroberts
Copy link
Member Author

cc: @ThomasBurleson

brandonroberts added a commit that referenced this issue May 10, 2018
@brandonroberts
feat(Schematics): Rename default action type for action blueprint
244d1de 
Closes #1040

BREAKING CHANGE:

The action blueprint has been updated to be less generic, with associated reducer and effects updated for the feature blueprint

BEFORE:

export enum UserActionTypes {
  UserAction = '[User] Action'
}

export class User implements Action {
  readonly type = UserActionTypes.UserAction;
}

export type UserActions = User;

AFTER:

export enum UserActionTypes {
  LoadUsers = '[User] Load Users'
}

export class LoadUsers implements Action {
  readonly type = UserActionTypes.LoadUsers;
}

export type UserActions = LoadUsers;
@brandonroberts brandonroberts mentioned this issue May 10, 2018
Merged
brandonroberts added a commit that referenced this issue May 10, 2018
@brandonroberts
feat(Schematics): Rename default action type for action blueprint (#1047
4c4e6a9 
)

Closes #1040

BREAKING CHANGE:

The action blueprint has been updated to be less generic, with associated reducer and effects updated for the feature blueprint

BEFORE:

export enum UserActionTypes {
  UserAction = '[User] Action'
}

export class User implements Action {
  readonly type = UserActionTypes.UserAction;
}

export type UserActions = User;

AFTER:

export enum UserActionTypes {
  LoadUsers = '[User] Load Users'
}

export class LoadUsers implements Action {
  readonly type = UserActionTypes.LoadUsers;
}

export type UserActions = LoadUsers;
@ThomasBurleson
Copy link
Contributor

@brandonroberts - darn. Now I have to check in the Nx Schematics if you have ALREADY done this work above. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.x Project: Schematics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonroberts @ThomasBurleson