Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Environments import path is off by one level when generating new store #1090

Closed
markgoho opened this issue May 23, 2018 · 3 comments

Comments

@markgoho
Copy link

markgoho commented May 23, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

use schematics to generate a new store
ng g store AppState --root --module app.module.ts --collection @ngrx/schematics
in app.module.ts the environment file path is incorrect
import { environment } from '../../environments/environment';

Expected behavior:

see the environment path file set to
import { environment } from '../environments/environment';

@markgoho markgoho changed the title Store: Environments import path is broken when generating new store Schematics: Environments import path is off by one level when generating new store May 23, 2018
@timdeschryver
Copy link
Member

Are you using the released version (6.0.1) or are you using the beta version?
Because I thought this was resolved in the released version.

@markgoho-EDT
Copy link

It looks like this was fixed in the reducer file, but not the app.module file

@timdeschryver
Copy link
Member

Oops, you're right.
I think I broke it with the reducer fix, sorry 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants