Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router-Store: Add custom serializer to config object #1262

Closed
brandonroberts opened this issue Aug 20, 2018 · 6 comments
Closed

Router-Store: Add custom serializer to config object #1262

brandonroberts opened this issue Aug 20, 2018 · 6 comments

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Currently you have to use the provider object syntax to override the default router state serializer. This can be easier by exposing a serializer option in the configuration with the custom serializer class. If none is provided, use the default.

@dummdidumm
Copy link
Contributor

#1010 related

@timdeschryver
Copy link
Member

Can I take this one? Or are you already working on it?

@dummdidumm
Copy link
Contributor

I have PR in the making implementing this and the other enhancement suggestions. I will request the merge soon.

@cyberbeast
Copy link

cyberbeast commented Sep 13, 2018

@brandonroberts Is this available in ngrx/router-store ^6.1.0? As far as I can tell, it currently isn't. If not, (and this might be a really stupid question), when will 6.1.1/6.2.0 be released that incorporates this?

@timdeschryver
Copy link
Member

This isn't available in 6.1. You could install ngrx from the nightly builds, these builds have the latest features.

@cyberbeast
Copy link

@timdeschryver Thank you for that information. I'll check that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants