You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Click the button, see unhandled error in the console
Expected behavior:
Router navigation errors resulting from a store initiated navigation should be handled. There already is a NAVIGATION_ERROR action, having it unhandled seems wrong. Instead the error could be handed to the ErrorHandler, so it just gets logged.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
Latest
Other information:
I would be willing to submit a PR to fix this issue
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered:
dummdidumm
added a commit
to dummdidumm/platform
that referenced
this issue
Aug 25, 2018
Minimal reproduction of the bug/regression with instructions:
https://stackblitz.com/edit/ngrx-seed-9chqaj?file=src%2Fapp%2Fapp.component.ts
Click the button, see unhandled error in the console
Expected behavior:
Router navigation errors resulting from a store initiated navigation should be handled. There already is a NAVIGATION_ERROR action, having it unhandled seems wrong. Instead the error could be handed to the ErrorHandler, so it just gets logged.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
Latest
Other information:
I would be willing to submit a PR to fix this issue
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: