Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router-Store: Navigation error resulting from store initiated route change is unhandled #1292

Closed
dummdidumm opened this issue Aug 25, 2018 · 0 comments · Fixed by #1294
Closed

Comments

@dummdidumm
Copy link
Contributor

Minimal reproduction of the bug/regression with instructions:

https://stackblitz.com/edit/ngrx-seed-9chqaj?file=src%2Fapp%2Fapp.component.ts

Click the button, see unhandled error in the console

Expected behavior:

Router navigation errors resulting from a store initiated navigation should be handled. There already is a NAVIGATION_ERROR action, having it unhandled seems wrong. Instead the error could be handed to the ErrorHandler, so it just gets logged.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

Latest

Other information:

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants