Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router Store: Add ng-add schematic #1479

Closed
brandonroberts opened this issue Dec 20, 2018 · 0 comments · Fixed by #1487
Closed

Router Store: Add ng-add schematic #1479

brandonroberts opened this issue Dec 20, 2018 · 0 comments · Fixed by #1487
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Schematics

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Would finish all the necessary packages to close out #920
ngfelixl added a commit to ngfelixl/platform that referenced this issue Dec 26, 2018
@ngfelixl
feat(schematics): implement router store ng-add
51790c2 
add ng-add schematics, add schema
implement tests

Closes ngrx#1479
@ngfelixl ngfelixl mentioned this issue Dec 26, 2018
Merged
3 tasks
brandonroberts pushed a commit that referenced this issue Dec 31, 2018
@ngfelixl @brandonroberts
feat(schematics): implement router store ng-add (#1487)
9da4aac 
Closes #1479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Schematics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(schematics): implement router store ng-add ngfelixl/platform
1 participant
@brandonroberts