Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: Clean up public API #1657

Closed
brandonroberts opened this issue Mar 29, 2019 · 0 comments · Fixed by #1679
Closed

Store: Clean up public API #1657

brandonroberts opened this issue Mar 29, 2019 · 0 comments · Fixed by #1679
Labels
Breaking Change Project: Store

Comments

@brandonroberts
Copy link
Member

Remove internal tokens, functions (ones starting with _) from public API exports
@timdeschryver timdeschryver mentioned this issue Apr 1, 2019
Merged
3 tasks
brandonroberts pushed a commit that referenced this issue Apr 1, 2019
@timdeschryver @brandonroberts
refactor(Store): don't export internal functions and tokens (#1679)
0446a15 
Closes #1657 

BREAKING CHANGE:

Internal functions and tokens are removed from the public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(Store): don't export internal functions and tokens ngrx/platform
2 participants
@brandonroberts @timdeschryver