Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: Add examples of effects not based on the Actions stream #1830

Closed
brandonroberts opened this issue May 7, 2019 · 1 comment · Fixed by #1845
Closed

Example: Add examples of effects not based on the Actions stream #1830

brandonroberts opened this issue May 7, 2019 · 1 comment · Fixed by #1845
Labels
community watch Someone from the community is working this issue/PR enhancement Project: Example App

Comments

@brandonroberts
Copy link
Member

Add more Observable based effects to show that Effects aren't restricted to listening to the Actions stream in order to return new actions. Some ideas:

  • A session timeout effect that is trigger when the user is idle for some amount of time. If the timeout expires, it dispatches an action to log out the user that is handled in AuthEffects
  • Listening to router events to update the page title on successful navigation. This would include adding page titles to the route configuration.

Open to other ideas about how to show this.
@adrianfaciu
Copy link

I can look into adding the examples for the ideas mentioned above.

adrianfaciu pushed a commit to adrianfaciu/platform that referenced this issue May 8, 2019
feat(example): add examples of effects not based on the Actions stream
199a37e 
As suggested, added two examples of effects not based on Actions stream:
- listen for router navigation events and update page title
- log out the user after a specified period of inactivity

Closes ngrx#1830
@adrianfaciu adrianfaciu mentioned this issue May 9, 2019
Merged
3 tasks
@brandonroberts brandonroberts added the community watch Someone from the community is working this issue/PR label May 14, 2019
adrianfaciu pushed a commit to adrianfaciu/platform that referenced this issue May 15, 2019
feat(example): add examples of effects not based on the Actions stream
38784a9 
As suggested, added two examples of effects not based on Actions stream:
- listen for router navigation events and update page title
- log out the user after a specified period of inactivity

Closes ngrx#1830
brandonroberts pushed a commit that referenced this issue May 21, 2019
@brandonroberts
feat(example): add examples of effects not based on the Actions stream (
3454e70 
#1845)

As suggested, added two examples of effects not based on Actions stream:
- listen for router navigation events and update page title
- log out the user after a specified period of inactivity

Closes #1830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community watch Someone from the community is working this issue/PR enhancement Project: Example App
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(example): add examples of effects not based on the Actions stream adrianfaciu/platform
2 participants
@brandonroberts @adrianfaciu