Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Generate selectors file as part of feature schematic #2140

Closed
brandonroberts opened this issue Oct 2, 2019 · 1 comment · Fixed by #2160 or TypescriptID/platform#268
Closed

Comments

@brandonroberts
Copy link
Member

It's common practice to have a separate {feature-name}.selectors.ts file alongside your actions, reducers, etc. The feature schematic would add a flag to generate this file and it's tests in addition to the current set, and eventually become the default.

We could optionally do this for the entity schematic also.

At a minimum, the selectors file would:

  • Import the usual createSelector functions
  • Import the reducer exports
  • Include a selector that uses createFeatureSelector to select that feature key
@timdeschryver
Copy link
Member

timdeschryver commented Oct 8, 2019

If no-one is currently working on this or is planning to work on this feature, I could grab this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants