-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ivy] 9.0.0-beta.0 - Life Cycle Effects Hook loses context #2373
Comments
Experiencing the same issue. This can be reproduced by adding an ngrxOnInitEffects to the NgRx example-app repo.
|
I haven't verified if this is the culprit, but there has been a change to |
@timdeschryver @brandonroberts when is the release date of NGRX 9 stable? |
No specific release date yet, but soon-ish. |
@jerryorta-dev fyi, this wasn't the cause of Ivy - see #2386 for more info |
NgRX 9.0.0-beta.0 , Angular 9.0.0, Node 12.3.0:
The lifecycle ngrxOnInitEffects is broken - it loses the context of "this" so code inside that hook doesn't understand the class properties, methods, constructor injections -- Rolling back to 8.6.0 works.
Other information:
I would be willing to submit a PR to fix this issue
[ ] Yes (Assistance is provided if you need help submitting a pull request)
[x] No
The text was updated successfully, but these errors were encountered: