Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when updating component-store via ng update schematic - An unhandled exception occurred: Cannot find module '@ngrx/component-store/./migrations/migration.json' #2819

Closed
wingy3181 opened this issue Dec 10, 2020 · 2 comments · Fixed by #2822

Comments

@wingy3181
Copy link
Contributor

Minimal reproduction of the bug/regression with instructions:

Don't have the time right now to setup an example but will do so later and add a comment to this issue later but had a look at the source and i think i found the issue. See "Other information"

  • Current project setup
    • @ngrx/component-store@10.0.0
  • Attempted to update to latest via schematic: ng update @ngrx/store
  • I get the following error message:
An unhandled exception occurred: Cannot find module '@ngrx/component-store/./migrations/migration.json'
Require stack:
....
  • Can see in node_modules it is indeed missing that folder/file for component store
    image

Expected behavior:

Should update @ngrx/component-store successfully

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

Ngrx: 10
Angular: 11.0.4
Node: 12
OS: OSX Big Sur

Other information:

I believe the following file is missing the assets attribute like the other modules

Also component module has the same issue (https://github.com/ngrx/platform/blob/master/modules/component/ng-package.json)

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@timdeschryver
Copy link
Member

I think you're right, do you want to create a Pull Request for this?

wingy3181 added a commit to wingy3181/platform that referenced this issue Dec 12, 2020
wingy3181 added a commit to wingy3181/platform that referenced this issue Dec 12, 2020
@wingy3181 wingy3181 mentioned this issue Dec 12, 2020
3 tasks
@wingy3181
Copy link
Contributor Author

@timdeschryver done
=)
See #2822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants