Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Remove ReactiveComponentModule #3623

Closed
1 of 2 tasks
markostanimirovic opened this issue Oct 20, 2022 · 0 comments · Fixed by #3643
Closed
1 of 2 tasks

Component: Remove ReactiveComponentModule #3623

markostanimirovic opened this issue Oct 20, 2022 · 0 comments · Fixed by #3643
Assignees
@markostanimirovic
Labels
15.x Project: Component

Comments

@markostanimirovic
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

component

Information

ReactiveComponentModule is deprecated in v14 and will be removed in v15. The migration guide is available here.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@markostanimirovic markostanimirovic self-assigned this Oct 20, 2022
@markostanimirovic markostanimirovic moved this to Todo in NgRx v15 Oct 20, 2022
markostanimirovic added a commit to markostanimirovic/platform that referenced this issue Nov 2, 2022
@markostanimirovic
feat(component): remove ReactiveComponentModule
3f7f539 
Closes ngrx#3623

BREAKING CHANGES:

ReactiveComponentModule is removed in favor of LetModule and PushModule.

BEFORE:

```ts
import { ReactiveComponentModule } from '@ngrx/component';

@NgModule({
  imports: [
    // ... other imports
    ReactiveComponentModule,
  ],
})
export class MyFeatureModule {}
```

AFTER:

```ts
import { LetModule, PushModule } from '@ngrx/component';

@NgModule({
  imports: [
    // ... other imports
    LetModule,
    PushModule,
  ],
})
export class MyFeatureModule {}
```
@markostanimirovic markostanimirovic mentioned this issue Nov 2, 2022
Merged
3 tasks
@markostanimirovic markostanimirovic moved this from Todo to In Progress in NgRx v15 Nov 2, 2022
Repository owner moved this from In Progress to Done in NgRx v15 Nov 3, 2022
timdeschryver pushed a commit that referenced this issue Nov 3, 2022
@markostanimirovic
feat(component): remove ReactiveComponentModule (#3643)
4bdf345 
Closes #3623

BREAKING CHANGE:

`ReactiveComponentModule` is removed in favor of `LetModule` and `PushModule`.

BEFORE:

```ts
import { ReactiveComponentModule } from '@ngrx/component';

@NgModule({
  imports: [
    // ... other imports
    ReactiveComponentModule,
  ],
})
export class MyFeatureModule {}
```

AFTER:

```ts
import { LetModule, PushModule } from '@ngrx/component';

@NgModule({
  imports: [
    // ... other imports
    LetModule,
    PushModule,
  ],
})
export class MyFeatureModule {}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markostanimirovic markostanimirovic

Labels
15.x Project: Component
Projects
No open projects
NgRx v15
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(component): remove ReactiveComponentModule markostanimirovic/platform
1 participant
@markostanimirovic