Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mergeMap operator in effects #3770

Closed
2 tasks
timdeschryver opened this issue Feb 8, 2023 · 0 comments · Fixed by #3779
Closed
2 tasks

update mergeMap operator in effects #3770

timdeschryver opened this issue Feb 8, 2023 · 0 comments · Fixed by #3779
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor

Comments

@timdeschryver
Copy link
Member

Information

To make a more realistic example with best practices we should update the mergeMap operator to exhaustMap within the effects docs.

This can be updated at https://github.com/ngrx/platform/edit/master/projects/ngrx.io/content/guide/effects/index.md

Documentation page

https://ngrx.io/guide/effects#writing-effects

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@timdeschryver timdeschryver added Comp: Docs Accepting PRs Good First Issue Good issue for first-time contributor community watch Someone from the community is working this issue/PR labels Feb 8, 2023
JeromeWirth added a commit to JeromeWirth/ngrx-platform that referenced this issue Feb 18, 2023
@JeromeWirth
docs(example): update to exhaustMap operator within the effects docs (n…
8a01375 
…grx#3770)

Updates the mergeMap operator to exhaustMap within the effects docs to make a more realistic example with best practices.

Closes ngrx#3770
@JeromeWirth JeromeWirth mentioned this issue Feb 18, 2023
Merged
3 tasks
JeromeWirth added a commit to JeromeWirth/ngrx-platform that referenced this issue Feb 18, 2023
@JeromeWirth
docs(example): revert incorrect replacement of exhaustMap with mergeM…
26261be 
…ap (ngrx#3770)

Closes ngrx#3770
brandonroberts pushed a commit that referenced this issue Feb 27, 2023
@JeromeWirth
docs(effects): use exhaustMap for loadMovies$ example (#3779)
6219fec 
Closes #3770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(effects): use exhaustMap for loadMovies$ example JeromeWirth/ngrx-platform
1 participant
@timdeschryver