-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to pass in custom memoization function for selectors #724
Comments
Hi @brandonroberts , |
@roopkt I already have a branch in the works for this, but thanks! Could you take a look at #604? I believe you added the original functionality |
hi @brandonroberts sure let me take a look thanks. |
Very impressed! Great job! |
Hi @brandonroberts |
This is amazing, but it's very hard to find! |
I'm submitting a...
What is the current behavior?
Currently the hardcoded memoization is instance equality check, which doesn't work well with arrays.
e.g. I have an array that changes on certain actions and there are many selectors for this data. Some/most selectors return the same items, but because it's a new array all the selector changes are needlessly triggered.
reselect
hascreateSelectorCreator
for that purpose.Expected behavior:
Minimal reproduction of the problem with instructions:
Version of affected browser(s),operating system(s), npm, node and ngrx:
Other information:
The text was updated successfully, but these errors were encountered: