Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): added noop for addFeature in MockReducerManager #2265

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

eddietisma
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

It is currently not possible to use provideMockStore if the component has a dependency to a module which uses forFeature imports.

StoreModule.forFeature('feature', FeatureReducer),
EffectsModule.forFeature([FeatureEffects]),

Currently crashes with:
TypeError: reducerManager.addFeatures is not a function

Closes #2263

What is the new behavior?

Added noop for addFeature.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 15, 2019

Preview docs changes for 82bb972 at https://previews.ngrx.io/pr2265-82bb972/

@brandonroberts brandonroberts merged commit c42e444 into ngrx:master Nov 20, 2019
@brandonroberts
Copy link
Member

Thanks @eddietisma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store: MockReducerManager crashes with reducerManager.addFeatures is not a function
3 participants