Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-store): migration to add the default serializer #2291

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

This migration will add the default router serializer during the ng update migration if it isn't explicitly set already.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR also adds a two utility functions (visitNgModuleImports and containsProperty)schematics-core.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Dec 11, 2019

Preview docs changes for aacd0e9 at https://previews.ngrx.io/pr2291-aacd0e9/

@brandonroberts brandonroberts merged commit b742a8c into master Jan 7, 2020
@timdeschryver timdeschryver deleted the router-serializer-migration branch January 15, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants