Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): EntityDataModuleWithoutEffect ModuleWithProviders #2366

Merged
merged 1 commit into from
Feb 10, 2020
Merged

fix(data): EntityDataModuleWithoutEffect ModuleWithProviders #2366

merged 1 commit into from
Feb 10, 2020

Conversation

debuggerpk
Copy link
Contributor

…Angular 9

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Related to #2356. Should have updated this one as well.

Closes #2356

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

How do i build this locally for testing so that i can test changes locally in before pushing the PR?

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 10, 2020

Preview docs changes for 1349b94 at https://previews.ngrx.io/pr2366-1349b94/

@timdeschryver timdeschryver changed the title fix(data): ModuleWithProvider for EntityDataModuleWithoutEffects for Angular 9 fix(data): EntityDataModuleWithoutEffect ModuleWithProviders Feb 10, 2020
@timdeschryver timdeschryver merged commit 234ce84 into ngrx:master Feb 10, 2020
@timdeschryver
Copy link
Member

Thanks @debuggerpk 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityDataModule.forRoot returns a ModuleWithProviders type without a generic type argument.
3 participants