Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data): change 'enableChangeTracking' reference to `noChangeTrack… #2463

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

donohoea
Copy link
Contributor

…ing`

change 'enableChangeTracking' reference to noChangeTracking and invert flag from 'false' to 'true'

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Current documentation references 'enableChangeTracking' as the metadata required to disable change tracking on a collection. This does not work as the current code base is looking for the 'noChangeTracking' flag.

What is the new behavior?

Updates documentation to reference 'noChangeTacking' and inverts the flag from false to true to match new context.

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

…ing`

change 'enableChangeTracking' reference to `noChangeTracking` and invert flag from 'false' to 'true'
@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 30, 2020

Preview docs changes for 10f68e0 at https://previews.ngrx.io/pr2463-10f68e0/

@timdeschryver timdeschryver merged commit c0dd2e5 into ngrx:master Apr 3, 2020
@timdeschryver
Copy link
Member

Thanks @donohoea !

@donohoea donohoea deleted the patch-2 branch April 3, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants