-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(entity): Call setAll instead of deprecated addAll #2484
docs(entity): Call setAll instead of deprecated addAll #2484
Conversation
It is indicated in the documentation that addAll has been deprecated in favor of setAll. In the reducer switch/case example, addAll was still being used instead of setAll.
Preview docs changes for 6b1eadd at https://previews.ngrx.io/pr2484-6b1eadd/ |
Thanks for the PR @keenanamigos! The file you should edit is here https://github.com/ngrx/platform/blob/master/projects/ngrx.io/content/guide/entity/adapter.md Those docs are the older versions that will be deleted soon. |
Ah, my mistake. Thanks for letting me know! I will make that change. |
…documentation This commit reverts the change to the old documentation and updates the new documentation with a call to setAll instead of addAll
@keenanamigos will you make one more change, and change the |
Thanks @keenanamigos! If you see anything else, feel free to open a new PR. |
Thanks a ton @brandonroberts! Sorry for the delay--I can still fix the other piece of documentation re: |
Sure. No rush |
It is indicated in the documentation that
addAll
has been deprecated in favor ofsetAll
. In the reducer switch/case example,addAll
was still being used instead ofsetAll
.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
No behavioral changes as this fix only affects documentation.
Does this PR introduce a breaking change?
Other information