-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add Nx workspace support #2535
Conversation
Preview docs changes for 45c2117 at https://previews.ngrx.io/pr2535-45c2117/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see this looks good!
I just have some problems building the project locally due to that I'm working on a Windows machine.
@brandonroberts I think that when the conflicts are resolved we could merge this in?
In a follow-up PR we could clean up the warnings while running the tests, and it also seems like ts-jest isn't too happy about the component tests (this could be from before).
Forgot about the example app... 😅
And I also think that the example tests aren't run during the CI. |
I'll get the copy commands cleaned up, and the example app test target. The Bazel build also broke while upgrading the packages 😞 so I'll need to either fix that, or we just leave it and switch over officially for V10. |
4aa2513
to
6393825
Compare
Will run with affected tests
1cf2570
to
19bb5d3
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information