Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add Nx workspace support #2535

Merged
merged 37 commits into from
May 29, 2020
Merged

build: add Nx workspace support #2535

merged 37 commits into from
May 29, 2020

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • Adds support for using an Nx workspace to build/test the NgRx libraries.
  • We will still have Bazel for build and deployment of npm packages, as this is considered a potential breaking change, but we will use Nx for all other tasks.
  • The Bazel BUILD files will remain.
  • Further tooling will be added for better release support

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 21, 2020

Preview docs changes for 45c2117 at https://previews.ngrx.io/pr2535-45c2117/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see this looks good!
I just have some problems building the project locally due to that I'm working on a Windows machine.

@brandonroberts I think that when the conflicts are resolved we could merge this in?

In a follow-up PR we could clean up the warnings while running the tests, and it also seems like ts-jest isn't too happy about the component tests (this could be from before).

angular.json Outdated Show resolved Hide resolved
angular.json Outdated Show resolved Hide resolved
@timdeschryver
Copy link
Member

Forgot about the example app... 😅
It seems like the tests don't run locally (could be me) while running yarn example:test

An unhandled exception occurred: Project 'example-app' does not support the 'test' target.
See "C:\Users\TDESCH~1\AppData\Local\Temp\ng-hYm7L5\angular-errors.log" for further details.

And I also think that the example tests aren't run during the CI.

@brandonroberts
Copy link
Member Author

I'll get the copy commands cleaned up, and the example app test target. The Bazel build also broke while upgrading the packages 😞 so I'll need to either fix that, or we just leave it and switch over officially for V10.

@brandonroberts brandonroberts force-pushed the add-nrwl-nx branch 2 times, most recently from 4aa2513 to 6393825 Compare May 28, 2020 04:19
angular.json Outdated Show resolved Hide resolved
@brandonroberts brandonroberts merged commit e8cd5be into master May 29, 2020
@brandonroberts brandonroberts deleted the add-nrwl-nx branch May 29, 2020 02:50
BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants