Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity): add mapOne #2628

Merged
merged 5 commits into from
Jul 24, 2020
Merged

feat(entity): add mapOne #2628

merged 5 commits into from
Jul 24, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2538

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

If we agree on the API, I can update the docs.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 22, 2020

Preview docs changes for 2def007 at https://previews.ngrx.io/pr2628-2def0078/

@timdeschryver
Copy link
Member Author

@brandonroberts do you got any ideas to make the build green? 😁

@brandonroberts
Copy link
Member

😁 Add --skip-nx-cache to the build-affected command in the .circleci/config.yml file for now. That should cause a full rebuild of each package instead of using the cloud cache. Just temporary for now and I'll take a look for a better fix.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Need to add it to the docs page for the adapter

@timdeschryver
Copy link
Member Author

@brandonroberts updated the docs, and I also exported EntityMapOne.

@brandonroberts brandonroberts merged commit d1891ad into master Jul 24, 2020
@brandonroberts brandonroberts deleted the pr/entity-map-one branch July 24, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/entity add mapOne method
3 participants