Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-store): allow more than 4 selects #2841

Merged
merged 2 commits into from
Jan 2, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2840

What is the new behavior?

Component Store's select method now uses variadic tuples types to allow an N number of inputs.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Dec 23, 2020

Preview docs changes for 218f3d3 at https://previews.ngrx.io/pr2841-218f3d3d/

Copy link
Member

@alex-okrushko alex-okrushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

Ideally I try to remove function overrides altogether, but this is definitely a step in the right direction 🙂 👍

modules/component-store/src/component-store.ts Outdated Show resolved Hide resolved
modules/component-store/src/component-store.ts Outdated Show resolved Hide resolved
modules/component-store/src/component-store.ts Outdated Show resolved Hide resolved
modules/component-store/src/component-store.ts Outdated Show resolved Hide resolved
Copy link
Member

@alex-okrushko alex-okrushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComponentStore: Allow combining more than 4 selectors
3 participants