Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): remove class-level generic from PushPipe #3127

Conversation

markostanimirovic
Copy link
Member

@markostanimirovic markostanimirovic commented Aug 27, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

PushPipe doesn't work properly with strictTemplates set to true.

Closes #3114

What is the new behavior?

PushPipe works with strictTemplates set to true.

Does this PR introduce a breaking change?

[x] Yes
[ ] No
BREAKING CHANGE:

PushPipe no longer has a class-level generic type parameter.
This change will affect the use of PushPipe outside of component templates.

BREAKING CHANGE:

PushPipe no longer has a class-level generic type parameter.
This change will affect the use of PushPipe outside of component templates.
@ngrxbot
Copy link
Collaborator

ngrxbot commented Aug 27, 2021

Preview docs changes for d14d8b3 at https://previews.ngrx.io/pr3127-d14d8b3a/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocsurfnut
Copy link

Any chance of this getting in for next NgRx minor release?

@brandonroberts
Copy link
Member

brandonroberts commented Sep 15, 2021

@ocsurfnut as its a breaking change, we won't include it in a minor release. It will be in the next major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngrxPush not working with strictTemplate checks
5 participants