Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): add workingDirectory to schemas #3473

Merged
merged 2 commits into from
Jun 28, 2022
Merged

fix(schematics): add workingDirectory to schemas #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ed459
fix(schematics): add workingDirectory to schemas
timdeschryver Jun 28, 2022
da9d5ed
test: fix e2e tests
timdeschryver Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/data/schematics/ng-add/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
"type": "string",
"format": "path",
"description": "The path to the module.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/effects/schematics/ng-add/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
"type": "string",
"format": "path",
"description": "The path to create the effect.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"flat": {
"type": "boolean",
Expand Down
5 changes: 4 additions & 1 deletion modules/router-store/schematics/ng-add/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
"type": "string",
"format": "path",
"description": "The path to create the router store.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/action/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/component-store/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component store.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/container/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/data/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
"type": "string",
"format": "path",
"description": "The path to create the service.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/effect/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/entity/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/feature/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"type": "string",
"format": "path",
"description": "The path to create the feature.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/reducer/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/selector/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
"type": "string",
"format": "path",
"description": "The path to create the selectors.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/schematics/src/store/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
"type": "string",
"format": "path",
"description": "The path to create the component.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/store-devtools/schematics/ng-add/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
"type": "string",
"format": "path",
"description": "The path to create the state.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
5 changes: 4 additions & 1 deletion modules/store/schematics/ng-add/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
"type": "string",
"format": "path",
"description": "The path to create the state.",
"visible": false
"visible": false,
"$default": {
"$source": "workingDirectory"
}
},
"project": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion projects/example-app-e2e/src/integration/round-trip.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ context('Full round trip', () => {
});

it('is possible to add books', () => {
cy.get('bc-book-preview').eq(2).click();
cy.get('bc-book-preview').eq(0).click();

cy.findByRole('button', { name: /add book to collection/i }).click();
cy.findByRole('button', { name: /add book to collection/i }).should(
Expand Down